[Asterisk-code-review] chan sip.c: Fix to stop MOH playing on held channel during a... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6124 )

Change subject: chan_sip.c:	Fix to stop MOH playing on held channel during attended transfer
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c@25627
PS1, Line 25627: 		AST_LIST_TRAVERSE(&bridge->channels, other, entry) {
> This is the responsibility of the core attended transfer and bridge code to
Ugh.  There isn't a core bridge case to handle this transfer scenario.  In fact, there is similar code in res_pjsip_refer.c:refer_incoming_invite_request().  It seems that only the SIP channel drivers need this API call.  There may be some transfer AMI events that we don't generate because of the core not having an API call for this.

What Josh says about traversing the bridge channel list still applies.



-- 
To view, visit https://gerrit.asterisk.org/6124
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a373263d92cf27c513013baefdd72ae1864c2ce
Gerrit-Change-Number: 6124
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Tomlinson <j.tomlinson at isi-com.com>
Gerrit-Reviewer: Jason Tomlinson <j.tomlinson at isi-com.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 31 Aug 2017 21:47:43 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170831/f08c516b/attachment-0001.html>