<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6124">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6124/1/channels/chan_sip.c@25627">Patch Set #1, Line 25627:</a> <code style="font-family:monospace,monospace">               AST_LIST_TRAVERSE(&bridge->channels, other, entry) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This is the responsibility of the core attended transfer and bridge code to</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ugh.  There isn't a core bridge case to handle this transfer scenario.  In fact, there is similar code in res_pjsip_refer.c:refer_incoming_invite_request().  It seems that only the SIP channel drivers need this API call.  There may be some transfer AMI events that we don't generate because of the core not having an API call for this.</p><p style="white-space: pre-wrap; word-wrap: break-word;">What Josh says about traversing the bridge channel list still applies.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6124">change 6124</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6124"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6a373263d92cf27c513013baefdd72ae1864c2ce </div>
<div style="display:none"> Gerrit-Change-Number: 6124 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Jason Tomlinson <j.tomlinson@isi-com.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jason Tomlinson <j.tomlinson@isi-com.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 31 Aug 2017 21:47:43 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>