[Asterisk-code-review] chan sip.c: Fix to stop MOH playing on held channel during a... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6124 )

Change subject: chan_sip.c:	Fix to stop MOH playing on held channel during attended transfer
......................................................................


Patch Set 1:

> If I lock the bridge before traversing the channels would this be
 > safe then ?
 > 
 > I also looked moving this into ast_bridge_impart and/or
 > bridge_impart_internal, but how would we know that it is for a
 > transfer? Or more precisely that the channels should be unheld?

Locking the bridge would make accessing the bridge channel list safe.

However, a new core API call should be created to do this transfer scenario as I think there are some missing AMI transfer events.


-- 
To view, visit https://gerrit.asterisk.org/6124
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a373263d92cf27c513013baefdd72ae1864c2ce
Gerrit-Change-Number: 6124
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Tomlinson <j.tomlinson at isi-com.com>
Gerrit-Reviewer: Jason Tomlinson <j.tomlinson at isi-com.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 31 Aug 2017 21:56:43 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170831/abf42a2e/attachment.html>