[Asterisk-code-review] Fix Alembic upgrades. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Fix Alembic upgrades.
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/3046/6/include/asterisk/config_options.h
File include/asterisk/config_options.h:

Line 292: 	 * This is nearly exactly the same as OPT_BOOL_T. The only difference is that when
s/nearly exactly/nearly/


Line 304: 	OPT_YESNO_T,
Should move this new value at the end of the enum for ABI compatibility.


https://gerrit.asterisk.org/#/c/3046/6/main/config_options.c
File main/config_options.c:

Line 90: 	"Boolean",			/* OPT_YESNO_T, */
Should move to the end of the array to match the enum for ABI compatibility.


PS6, Line 143: bool_handler_fn
> That's not actually necessary. This file handles how we handle options from
We should add a comment to that effect here.


-- 
To view, visit https://gerrit.asterisk.org/3046
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I366dbbf91418a9cb160b3ca74b0e59b5ac284bec
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes