[Asterisk-code-review] Fix Alembic upgrades. (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Wed Jun 22 10:59:34 CDT 2016


Alexei Gradinari has posted comments on this change.

Change subject: Fix Alembic upgrades.
......................................................................


Patch Set 6: -Code-Review

> (1 comment)

I think better to restrict values to 'yes'/'no' for this new type.

"Newer generation code takes a strict approach on that - an invalid configuration can present unexpected behavior, so providing the information of why it is wrong and rejecting it is the behavior going forward." Joshua Colp (c)

-- 
To view, visit https://gerrit.asterisk.org/3046
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I366dbbf91418a9cb160b3ca74b0e59b5ac284bec
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list