[Asterisk-code-review] Fix Alembic upgrades. (asterisk[13])

Mark Michelson asteriskteam at digium.com
Wed Jun 22 10:51:27 CDT 2016


Mark Michelson has posted comments on this change.

Change subject: Fix Alembic upgrades.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/3046/6/main/config_options.c
File main/config_options.c:

PS6, Line 143: bool_handler_fn
> should be yesno_handler_fn
That's not actually necessary. This file handles how we handle options from configuration files. For booleans and these "yesno" values, we will accept any boolean. The difference between the two types is strictly in what we output. That's why only sorcery.c requires a special handler for the new type.


-- 
To view, visit https://gerrit.asterisk.org/3046
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I366dbbf91418a9cb160b3ca74b0e59b5ac284bec
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list