[Asterisk-code-review] core: Entity ID is not set or invalid (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: core: Entity ID is not set or invalid
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/3456/2/res/res_corosync.c
File res/res_corosync.c:

Line 1166: 		ast_log(LOG_WARNING, "Entity ID is not set.\n");
> If the EID isn't set, should we instead consider the module load 'failed'? 
I think in the same way.
But it should be the same for all modules, i.e XMPP, PSJIP, Corosync.
Should I change all modules to return AST_MODULE_LOAD_DECLINE?


-- 
To view, visit https://gerrit.asterisk.org/3456
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72d712f1ad5b6f64571bb179c5cb12461e7c58c6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes