[Asterisk-code-review] core: Entity ID is not set or invalid (asterisk[13])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: core: Entity ID is not set or invalid
......................................................................


Patch Set 2:

> (1 comment)

I think so for res_pjsip_publish_asterisk, since you're liable to have functionality that just flat out won't work.

res_xmpp is a lot harder call to make. You can use res_xmpp without distributing device state or MWI:
(1) You can simply have Asterisk tied into Jabber servers, acting as a system within chat rooms.
(2) You could be integrated with Google Voice via chan_motif, or using Jingle.

If one of those systems didn't have an EID, they would be functional today. If we DECLINE module load for them with this patch, we could conceivable cause those systems to suddenly stop working.

Personally, I think the DECLINE for those systems that *need* an EID makes a lot of sense; in other cases where an EID is not necessary for their functionality, I'd log a very nasty WARNING and let them continue on.

-- 
To view, visit https://gerrit.asterisk.org/3456
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72d712f1ad5b6f64571bb179c5cb12461e7c58c6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No