[Asterisk-code-review] core: Entity ID is not set or invalid (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change.

Change subject: core: Entity ID is not set or invalid
......................................................................


Patch Set 2:

> > Would it make sense if no id was specified in the config file,
 > and
 > > it could not be obtained from the ethernet device to have
 > Asterisk
 > > attempt to randomly create one instead of leaving it empty? Maybe
 > > somehow convert the pbx uuid to a mac address format?
 > 
 > The problem is that the EID is *far* smaller than a normally
 > generated UUID. It relies on the hardware being present, or else a
 > user manually entering the value. I think it'd be extremely
 > difficult to generate anything that could be considered unique
 > ourselves.

I think we shouldn't auto generate EID.
Better to add important notice to corresponding documentation.
The configuration of the exchanging states is complex task,
so one of the task should be properly configure EID.

-- 
To view, visit https://gerrit.asterisk.org/3456
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72d712f1ad5b6f64571bb179c5cb12461e7c58c6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No