[Asterisk-code-review] Allow command-line options to override asterisk.conf. (asterisk[master])

[Ashley Sanders]

Ashley Sanders has posted comments on this change.

Change subject: Allow command-line options to override asterisk.conf.
......................................................................


Patch Set 3:

(3 comments)

I just have a few small suggestions. The code looks good to me.

https://gerrit.asterisk.org/#/c/392/3//COMMIT_MSG
Commit Message:

Line 14: then it processes the remaining options after config is read.
Small nit-pick: [...] after the config is read.


https://gerrit.asterisk.org/#/c/392/3/CHANGES
File CHANGES:

Line 107:  * Most command-line options are now processed after asterisk.conf.  The
I think it would be good to list in this blurb the command line options that are processed first (X, C, d, h, R, r, x, V, v, ?).


https://gerrit.asterisk.org/#/c/392/3/UPGRADE.txt
File UPGRADE.txt:

Line 39:  - Most command-line options are now processed after asterisk.conf.  The
Just like in the CHANGES file, I think it would be good to list in this blurb the command line options that are processed first (X, C, d, h, R, r, x, V, v, ?).


-- 
To view, visit https://gerrit.asterisk.org/392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes