[Asterisk-code-review] Allow command-line options to override asterisk.conf. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Allow command-line options to override asterisk.conf.
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/392/3/CHANGES
File CHANGES:

Line 110:    enable #exec from other config files you must set execincludes=yes in
...#exec for other...


https://gerrit.asterisk.org/#/c/392/3/UPGRADE.txt
File UPGRADE.txt:

Line 42:    enable #exec from other config files you must set execincludes=yes in
...#exec for other...


https://gerrit.asterisk.org/#/c/392/3/main/asterisk.c
File main/asterisk.c:

Line 3355: 	printf("   -d              Enable extra debugging\n");
Document same as -v here?


Line 3500: 				option_debug_new = ast_true(v->value);
Hmm.  ast_true() returns -1 for truth value.  Probably not a good value to be adding later.


-- 
To view, visit https://gerrit.asterisk.org/392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes