[Asterisk-code-review] Allow command-line options to override asterisk.conf. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Allow command-line options to override asterisk.conf.
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/#/c/392/3/CHANGES
File CHANGES:

Line 107:  * Most command-line options are now processed after asterisk.conf.  The
> I think it would be good to list in this blurb the command line options tha
I don't agree.  Let me explain for each option.
* X: Already specifically mentioned.
* C: Set the location of asterisk.conf, it's read when it has to be, changing it would make no sense.
* d/v: Debug and verbose are processed first, but the effective result is as if they are processed after asterisk.conf.  So these options are not an exception, the behaviour has been fixed (verbose=0 in Asterisk.conf will no longer override 'asterisk -vvv').
* h/V/?: help, version, and 'invalid argument' - these just print and exit, really not worth bulking up the changes file to mention.
* R/r/x: These are not fully processed in the first loop, we are just presetting the AST_OPT_FLAG_REMOTE, as it needs to be known by ast_readconfig.  These arguments are fully processed after reading asterisk.conf.  This is in internal implementation detail that users need not be concerned with.  I have improved the comment in asterisk.c for this.


https://gerrit.asterisk.org/#/c/392/3/UPGRADE.txt
File UPGRADE.txt:

Line 39:  - Most command-line options are now processed after asterisk.conf.  The
> Just like in the CHANGES file, I think it would be good to list in this blu
Same response as for CHANGES.


https://gerrit.asterisk.org/#/c/392/3/main/asterisk.c
File main/asterisk.c:

Line 3500: 				option_debug_new = ast_true(v->value);
> Hmm.  ast_true() returns -1 for truth value.  Probably not a good value to 
This is a bug in existing versions.  Addressing as a separate commit to precede this one.


-- 
To view, visit https://gerrit.asterisk.org/392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes