[Asterisk-code-review] Allow command-line options to override asterisk.conf. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Allow command-line options to override asterisk.conf.
......................................................................


Patch Set 3:

> I do like the new behaviour.
 > 
 > The one aspect of it that I found interesting was making the
 > '-v/-d' command line option cumulative with the verbose/debug
 > settings in asterisk.conf. I'm not against it working that way, but
 > I had to reconsider how I viewed the '-v/-d' options to understand
 > why it was working that way. With that behaviour, it isn't so much
 > that the command line options are overriding the asterisk.conf
 > settings, so much as supplementing it.
 > 
 > I'm fine with it working that way, however.

>From asterisk -h:
-d              Enable extra debugging
-v              Increase verbosity (multiple v's = more verbose)

Maybe the help message for '-d' should be updated to look more like the message for '-v'?  The man page is clear on this already.  I think the new way '-v/-d' work is exactly what the documentation says it will do, increase the level.  The implementation make it look weird is because I wanted '-vvv' to increase the verbose from 0 to 3 before loading asterisk.conf, then act like the -v/-d were processed after asterisk.conf.  If I didn't do this '-v/-d' would be processed in the 2nd getopts loop with no changes from previous code and this would have gone unnoticed.

-- 
To view, visit https://gerrit.asterisk.org/392
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1450d45c15b4467274b871914d893ed4f6564cd7
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No