[Asterisk-code-review] app directory: Fix crash when using the alias option 'a'. (asterisk[certified/13.1])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: app_directory: Fix crash when using the alias option 'a'.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/640/1/apps/app_directory.c
File apps/app_directory.c:

Line 694: 				for (v = ast_variable_browse(ucfg, cat); v; v = v->next) {
> I'm going to agree with Scott here. I think the proper fix is to keep the o
Yes I'm sure that v can be reused here.  It is the loop variable used for the voicemail.conf section processing loop and it is being reused as the loop varible here for the users.conf section processing loop.  The loops are not nested.

What brought my attention to this bug was that the local alias variable I removed was shadowing the main function block alias variable.


-- 
To view, visit https://gerrit.asterisk.org/640
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86052ea77307beddddba5279824d39dc0d593374
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes