[Asterisk-code-review] app directory: Fix crash when using the alias option 'a'. (asterisk[certified/13.1])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: app_directory: Fix crash when using the alias option 'a'.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/640/1/apps/app_directory.c
File apps/app_directory.c:

Line 694: 				for (v = ast_variable_browse(ucfg, cat); v; v = v->next) {
> Are you sure you can get away with re-using V here?
I'm going to agree with Scott here. I think the proper fix is to keep the old "alias" ast_variable and use it in the comparisons below instead of "v"


-- 
To view, visit https://gerrit.asterisk.org/640
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86052ea77307beddddba5279824d39dc0d593374
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes