[Asterisk-code-review] app directory: Fix crash when using the alias option 'a'. (asterisk[certified/13.1])

Mark Michelson asteriskteam at digium.com
Thu Jun 11 23:40:31 CDT 2015


Mark Michelson has posted comments on this change.

Change subject: app_directory: Fix crash when using the alias option 'a'.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/640/1/apps/app_directory.c
File apps/app_directory.c:

Line 694: 				for (v = ast_variable_browse(ucfg, cat); v; v = v->next) {
> Yes I'm sure that v can be reused here.  It is the loop variable used for t
Gotcha. I'm going to blame gerrit's diff viewer on this one since it appears that the ucfg loop is nested inside the vmcfg loop.


-- 
To view, visit https://gerrit.asterisk.org/640
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86052ea77307beddddba5279824d39dc0d593374
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Scott Griepentrog <sgriepentrog at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list