[asterisk-bugs] [LibPRI 0017405]: BRI TE assignment logic is absolutely wrong.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17405 
====================================================================== 
Reported By:                ddv2005
Assigned To:                
====================================================================== 
Project:                    LibPRI
Issue ID:                   17405
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           Addons-1.6.1 - SECURITY ONLY! 
JIRA:                        
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-26 12:51 CDT
Last Modified:              2010-06-07 11:34 CDT
====================================================================== 
Summary:                    BRI TE assignment logic is absolutely wrong.
Description: 
BRI TE assignment logic is absolutely wrong. Usually each BRI port have 2
BRI channels. For BRI NT PTMP mode each channel request separate D-Channel
by sending Q921_TEI_IDENTITY_REQUEST. And BRI NT software MUST support
several subchannels. But your implementation does not support more than one
subchannel. Your implementation for Q921_TEI_IDENTITY_REMOVE/
Q921_TEI_IDENTITY_ASSIGNED/ Q921_TEI_IDENTITY_CHECK_REQUEST look depth only
at one subchannel. Like this:
=============================================================
	case Q921_TEI_IDENTITY_REMOVE:
		if (!BRI_TE_PTMP(pri))
			return NULL;

		if ((tei == Q921_TEI_GROUP) || (tei == pri->subchannel->tei)) {
			q921_setstate(pri->subchannel, Q921_TEI_UNASSIGNED);
			q921_start(pri->subchannel);
		}
=============================================================
====================================================================== 

---------------------------------------------------------------------- 
 (0123063) mattf (administrator) - 2010-06-07 11:34
 https://issues.asterisk.org/view.php?id=17405#c123063 
---------------------------------------------------------------------- 
I believe that either I don't understand what you're getting at, or you're
incorrect in your understanding of that code.

This code is only used when Asterisk is *acting* as a TE-PTMP device.  In
this case, Asterisk only handles the line using a single TEI and will only
have a single subchannel to control both B-channels. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-07 11:34 mattf          Note Added: 0123063                          
======================================================================