[asterisk-bugs] [LibPRI 0017405]: BRI TE assignment logic is absolutely wrong.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17405 
====================================================================== 
Reported By:                ddv2005
Assigned To:                
====================================================================== 
Project:                    LibPRI
Issue ID:                   17405
Category:                   General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           Addons-1.6.1 - SECURITY ONLY! 
JIRA:                        
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2010-05-26 12:51 CDT
Last Modified:              2010-06-07 11:41 CDT
====================================================================== 
Summary:                    BRI TE assignment logic is absolutely wrong.
Description: 
BRI TE assignment logic is absolutely wrong. Usually each BRI port have 2
BRI channels. For BRI NT PTMP mode each channel request separate D-Channel
by sending Q921_TEI_IDENTITY_REQUEST. And BRI NT software MUST support
several subchannels. But your implementation does not support more than one
subchannel. Your implementation for Q921_TEI_IDENTITY_REMOVE/
Q921_TEI_IDENTITY_ASSIGNED/ Q921_TEI_IDENTITY_CHECK_REQUEST look depth only
at one subchannel. Like this:
=============================================================
	case Q921_TEI_IDENTITY_REMOVE:
		if (!BRI_TE_PTMP(pri))
			return NULL;

		if ((tei == Q921_TEI_GROUP) || (tei == pri->subchannel->tei)) {
			q921_setstate(pri->subchannel, Q921_TEI_UNASSIGNED);
			q921_start(pri->subchannel);
		}
=============================================================
====================================================================== 

---------------------------------------------------------------------- 
 (0123064) ddv2005 (reporter) - 2010-06-07 11:41
 https://issues.asterisk.org/view.php?id=17405#c123064 
---------------------------------------------------------------------- 
I has implemented BRI NT PTMP mode for previous version of libpri. And has
tested my implementation with several USA BRI equipment. In all cases the
client device requested separate TIE for each B-channel. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-06-07 11:41 ddv2005        Note Added: 0123064                          
======================================================================