[asterisk-bugs] [Asterisk 0005337]: Makefile detection of $MODCONF is broken, causes failure during make install

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=5337 
====================================================================== 
Reported By:                timecop
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   5337
Category:                   Core/General
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             09-29-2005 19:34 CDT
Last Modified:              06-07-2008 11:04 CDT
====================================================================== 
Summary:                    Makefile detection of $MODCONF is broken, causes
failure during make install
Description: 
If a system does not use automatic module loading,
and thus does not have /etc/modules.conf or whatever the makefile is
searching for, then later on during make install it will error:

if [ -f  ]; then mv -f  .bak ; fi
mv: missing file argument
Try `mv --help' for more information.
make: *** [install] Error 1

Proposed solution would be to either:
a) assign default value of MODCONF variable to /etc/modules.conf
b) provide a default else fallback which assigns it to /etc/modules.conf
c) modify the Makefile to skip mucking with modules.conf location if the
file was not found (MODCONF is unassigned)

====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 11:04  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 787

U   trunk/Makefile

------------------------------------------------------------------------
r787 | kpfleming | 2008-06-07 11:04:55 -0500 (Sat, 07 Jun 2008) | 2 lines

don't try to mess with module configuration file if it's not found (issue
http://bugs.digium.com/view.php?id=5337)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=787 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 11:04  svnbot         Checkin                                      
06-07-08 11:04  svnbot         Note Added: 0088071                          
======================================================================