[asterisk-bugs] [Asterisk 0005316]: [patch] zaptel.c has unchecked calls to copy_from_user() and copy_to_user()

noreply at bugs.digium.com noreply at bugs.digium.com
Sat Jun 7 11:04:44 CDT 2008


A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=5316 
====================================================================== 
Reported By:                softins
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   5316
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           I did not set the version :( 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        Yes 
Request Review:             Yes 
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             09-28-2005 09:41 CDT
Last Modified:              06-07-2008 11:04 CDT
====================================================================== 
Summary:                    [patch] zaptel.c has unchecked calls to
copy_from_user() and copy_to_user()
Description: 
In zaptel.c, some invocations of copy_from_user() and copy_to_user() do not
have their return value checked, which results in compiler warnings when
compiling under Linux 2.6 (see below).

Also, some calls which are checked, return -EIO as the error code instead
of -EFAULT.

The attached patch corrects both of the above.
====================================================================== 

---------------------------------------------------------------------- 
 svnbot - 06-07-08 11:04  
---------------------------------------------------------------------- 
Repository: dahdi
Revision: 782

U   trunk/zaptel.c

------------------------------------------------------------------------
r782 | kpfleming | 2008-06-07 11:04:43 -0500 (Sat, 07 Jun 2008) | 2 lines

check results of copy_from/to_user (issue
http://bugs.digium.com/view.php?id=5316)

------------------------------------------------------------------------

http://svn.digium.com/view/dahdi?view=rev&revision=782 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
06-07-08 11:04  svnbot         Checkin                                      
06-07-08 11:04  svnbot         Note Added: 0088070                          
======================================================================




More information about the asterisk-bugs mailing list