[test-results] [Bamboo] Asterisk - 1.8 > Ubuntu Lucid (10.04) > #157 was SUCCESSFUL (with 205 tests). Change made by jpeeler.
Bamboo
bamboo at asterisk.org
Fri Jan 14 12:02:52 CST 2011
-----------------------------------------------------------------------
Asterisk - 1.8 > Ubuntu Lucid (10.04) > #157 was successful.
-----------------------------------------------------------------------
Code has been updated by jpeeler.
All 2 jobs passed with 205 tests in total.
http://bamboo.asterisk.org/browse/AST18-LUCID-157/
--------------
Code Changes
--------------
jpeeler (301790):
>Resolve deadlock involving REFER.
>
>Two fixes:
>1) One must always have the private unlocked before calling
>pbx_builtin_setvar_helper to not invalidate locking order since it locks the
>channel.
>2) Unlock the channel before calling pbx_find_extension, which starts and stops
>autoservice during the lookup. The problem scenario as illustrated by the
>reporter:
>
>Thread: do_monitor
>-----------------------
>handle_request_do
> handle_incoming
> handle_request_refer
> ast_parking_ext_valid
> pbx_find_extension
> ast_autoservice_stop
> while (chan_list_state == as_chan_list_state) { usleep(1000); }
>
>Thread: autoservice_run
>-----------------------
>autoservice_run
> chan = ast_waitfor_n
> ast_waitfor_nandfds
> ast_waitfor_nandfds_classic / simple / complex (depending on your system)
> ast_channel_lock(c[x]);
>
>handle_request_do and schedule_process_request_queue locks the owner
>if it exists. The autoservice thread is waiting for the channel lock, which
>wasn't ever released since the do_monitor thread was waiting for autoservice
>operations to complete. Solved by unlocking the channel but keeping a reference
>to guarantee safety.
>
>(closes issue #18403)
>Reported by: jthurman
>Patches:
> 20110103-blind_deadlock.diff uploaded by jthurman (license 614)
> issue18403.patch uploaded by jpeeler (license 325)
>Tested by: jthurman
>
>
--------------
Tests
--------------
Fixed Tests (1)
- AsteriskTestSuite: S/chanspy/chanspy barge
--
This message is automatically generated by Atlassian Bamboo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/test-results/attachments/20110114/2c130da3/attachment.htm>
More information about the Test-results
mailing list