<div>
<style type="text/css">
.successful a, .successful a:visited, .successful a:link, .successful a:hover,.successful a:active {color:#393}
.failed a, .failed a:visited, .failed a:link, .failed a:hover,.failed a:active {color:#d62829}
.notexecuted a, .notexecuted a:visited, .notexecuted a:link, .notexecuted a:hover,.notexecuted a:active {color:#ffcc66}
td a, td a:link, td a:visited, td a:hover, td a:active {background:transparent;font-family: Arial, sans-serif;text-decoration:underline;}
td a:link {color:#369;}
td a:visited {color:#444;}
td a:hover, td a:active {color:#036;}
td a:hover {text-decoration:none;}
</style>
<font size="2" color="black" face="Arial, Helvetica, sans-serif" style="font-family: Arial, sans-serif;font-size: 13px;color:#000">
<table align="center" border="0" cellpadding="5" cellspacing="0" width="98%">
<tr>
<td style="vertical-align:top">
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#e4f5e3;border-top:1px solid #b4e2b4;border-bottom:1px solid #b4e2b4;color:#393;">
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/jt/icn_plan_passed.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#393;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#393">Asterisk - 1.8</a> >
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#393">Ubuntu Lucid (10.04)</a> >
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157/" style="font-family: Arial, sans-serif; font-size: 15px; font-weight:bold; color:#393">#157</a>
<span class="successful" style="font-family: Arial, sans-serif; font-size: 14px;"> was successful.</span>
<span class="successful" style="font-family: Arial, sans-serif; font-size: 13px;">
<br/>Code has been updated by <a href="http://bamboo.asterisk.org/browse/author/jpeeler">jpeeler</a>.
<br/>All <strong>2</strong> jobs passed with <strong>205</strong> tests in total. </span>
</td>
</tr>
</table>
<br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157/commit/" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Code Changes</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157/commit/" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">See full change details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td width="20" style="vertical-align:top;padding:10px 0 0px 10px">
<img src="http://bamboo.asterisk.org/images/icons/businessman.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:10px 10px 0px 10px">
<a href="http://bamboo.asterisk.org/browse/author/jpeeler" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000">
jpeeler</a><br>
Resolve deadlock involving REFER.<br/>
<br/>
Two fixes:<br/>
1) One must always have the private unlocked before calling<br/>
pbx_builtin_setvar_helper to not invalidate locking order since it locks the<br/>
channel.<br/>
2) Unlock the channel before calling pbx_find_extension, which starts and stops<br/>
autoservice during the lookup. The problem scenario as illustrated by the<br/>
reporter:<br/>
<br/>
Thread: do_monitor<br/>
-----------------------<br/>
handle_request_do<br/>
handle_incoming<br/>
handle_request_refer<br/>
ast_parking_ext_valid<br/>
pbx_find_extension<br/>
ast_autoservice_stop<br/>
while (chan_list_state == as_chan_list_state) { usleep(1000); }<br/>
<br/>
Thread: autoservice_run<br/>
-----------------------<br/>
autoservice_run<br/>
chan = ast_waitfor_n<br/>
ast_waitfor_nandfds<br/>
ast_waitfor_nandfds_classic / simple / complex (depending on your system)<br/>
ast_channel_lock(c[x]);<br/>
<br/>
handle_request_do and schedule_process_request_queue locks the owner<br/>
if it exists. The autoservice thread is waiting for the channel lock, which<br/>
wasn't ever released since the do_monitor thread was waiting for autoservice<br/>
operations to complete. Solved by unlocking the channel but keeping a reference<br/>
to guarantee safety.<br/>
<br/>
(closes issue #18403)<br/>
Reported by: jthurman<br/>
Patches: <br/>
20110103-blind_deadlock.diff uploaded by jthurman (license 614)<br/>
issue18403.patch uploaded by jpeeler (license 325)<br/>
Tested by: jthurman<br/>
<br/>
</td>
<td width="60" style="font-family: Arial, sans-serif; font-size: 13px; ;color:#036;vertical-align:top;padding:10px 10px 0px 10px">
(301790)
</td></tr>
</table><br>
<table width="100%" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td width="60%" style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157/test" style="text-decoration: none; font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036" >Tests</a>
</td>
<td width="40%" style="font-family: Arial, sans-serif;text-align:right;font-size:13px;color:#036;padding:5px 10px">
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#036">See full test details</a><img src="http://bamboo.asterisk.org/images/icons/more.gif" width="15" height="15" style="vertical-align:middle;padding:2px">
</td>
</tr>
</table>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr>
<td colspan="2" width="100%" style="font-family: Arial, sans-serif; font-size: 13px; font-weight:bold; color:#000;vertical-align:top;padding:10px 0 0 10px">
Fixed Tests (1)
</td>
</tr>
<tr>
<td width="20" style="vertical-align:top;padding:5px 0 5px 10px">
<img src="http://bamboo.asterisk.org/images/jt/icn_plan_passed.gif" width="15" height="15">
</td>
<td width="100%" style="font-family: Arial, sans-serif; font-size: 13px; color:#000;vertical-align:top;padding:5px 10px">
AsteriskTestSuite :
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-157/test/case/5375672" style="font-family: Arial, sans-serif; font-size: 13px;color:#000">S/chanspy/chanspy barge</a>
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-AMD64-157/test" style="font-family: Arial, sans-serif; font-size: 13px;color:#999">(amd64)</a>
</td>
</tr> </table><br>
</td>
<td width="150" style="vertical-align:top">
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#ecf1f7;border-top:1px solid #bbd0e5;border-bottom:1px solid #bbd0e5;color:#036;">
<tr>
<td style="font-family: Arial, sans-serif;text-align:left;font-size:16px;font-weight:bold;color:#036;vertical-align:top;padding:5px 10px">
Actions
</td>
</tr>
</table>
<table width="150" border="0" cellpadding="0" cellspacing="0" style="background-color:#f5f9fc;border-bottom:1px solid #bbd0e5;">
<tr>
<td style="font-family: Ariel, sans-serif; font-size: 13px; color:#036;vertical-align:top;padding:5px 10px;line-height:1.7">
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">View Online</a>
<br>
<a href="http://bamboo.asterisk.org/browse/AST18-LUCID-157?commentMode=true" style="font-family: Arial, sans-serif; font-size: 13px; color:#036">Add Comments</a>
<br>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td>
<table width="100%" border="0" cellpadding="0" cellspacing="0">
<tr><td colspan="2" align="center" style="font-family: Arial, sans-serif;text-align:center;font-size:11px;font-weight:bold;color:#999;vertical-align:top;padding:20px">
Email generated by <a href="http://bamboo.asterisk.org" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">Atlassian Bamboo</a> - if you wish to stop receiving these emails edit your <a href="http://bamboo.asterisk.org/profile/userNotifications.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">user profile</a> or <a href="http://bamboo.asterisk.org/viewAdministrators.action" style="font-family: Arial, sans-serif; font-size: 11px; color:#999">notify your administrator</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</font>
</div>