[asterisk-dev] [Code Review] 4199: test_channel_feature_hooks.c: Fix unit test for DTMF hooks.

rmudgett reviewboard at asterisk.org
Mon Nov 24 14:26:45 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4199/
-----------------------------------------------------------

(Updated Nov. 24, 2014, 2:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 428601


Repository: Asterisk


Description
-------

Fix the failing /channels/features/test_features_channel_dtmf unit test.

DTMF emulation does not work without a stream of packets to prod the emulation code.

The changes to main/bridge_channel.c and main/bridge.c will be done to v12+.  Any partially collected DTMF digits for DTMF a hook needs to be pushed into the bridge when a channel leaves the bridging system as if there were a timeout.


Diffs
-----

  /branches/13/tests/test_channel_feature_hooks.c 428271 
  /branches/13/main/bridge_channel.c 428271 
  /branches/13/main/bridge.c 428271 

Diff: https://reviewboard.asterisk.org/r/4199/diff/


Testing
-------

The unit test now passes.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141124/0a38d19b/attachment.html>


More information about the asterisk-dev mailing list