[asterisk-dev] [Code Review] 4199: test_channel_feature_hooks.c: Fix unit test for DTMF hooks.
Matt Jordan
reviewboard at asterisk.org
Sun Nov 23 20:51:31 CST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4199/#review13843
-----------------------------------------------------------
Ship it!
Ship It!
- Matt Jordan
On Nov. 19, 2014, 5:27 p.m., rmudgett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4199/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2014, 5:27 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Fix the failing /channels/features/test_features_channel_dtmf unit test.
>
> DTMF emulation does not work without a stream of packets to prod the emulation code.
>
> The changes to main/bridge_channel.c and main/bridge.c will be done to v12+. Any partially collected DTMF digits for DTMF a hook needs to be pushed into the bridge when a channel leaves the bridging system as if there were a timeout.
>
>
> Diffs
> -----
>
> /branches/13/tests/test_channel_feature_hooks.c 428271
> /branches/13/main/bridge_channel.c 428271
> /branches/13/main/bridge.c 428271
>
> Diff: https://reviewboard.asterisk.org/r/4199/diff/
>
>
> Testing
> -------
>
> The unit test now passes.
>
>
> Thanks,
>
> rmudgett
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141124/3d144519/attachment.html>
More information about the asterisk-dev
mailing list