[asterisk-dev] [Code Review] 3378: [main/say.c] SayNumber for Polish language tries to play empty files for numbers divisible by 100

[zvision]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3378/
-----------------------------------------------------------

(Updated March 20, 2014, 10:36 p.m.)


Review request for Asterisk Developers.


Bugs: ASTERISK-23509
    https://issues.asterisk.org/jira/browse/ASTERISK-23509


Repository: Asterisk


Description
-------

SayNumber diaplan application tries to play an invalid/empty sound file (digits/) for numbers divisible by 100 when Polish language is selected.
First it plays a correct sound (digits/100, for example) and then it tries to play an empty file. The number spelled is correct,
but Asterisk gives WARNINGs about a missing file.

The problem is an incorrect check while playing tenths sound - it tries to play a tenths sound when number is 0.

The patch fixes the problem and clarifies a bit other checks.


Diffs
-----

  http://svn.asterisk.org/svn/asterisk/branches/1.8/main/say.c 410948 

Diff: https://reviewboard.asterisk.org/r/3378/diff/


Testing (updated)
-------

Tested by listening to various number sequences, everything seems to be fine.


Thanks,

zvision

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140320/8572a380/attachment.html>