[asterisk-dev] [Code Review] 3378: [main/say.c] SayNumber for Polish language tries to play empty files for numbers divisible by 100

[zvision]

> On March 20, 2014, 9:08 p.m., Mark Michelson wrote:
> > I don't speak Polish, but the code changes you've made are within the coding guidelines. If the changes are working for you, then this change is fine to go in.

Yes, I've just finished testing and everything seems to be fine.


- zvision


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3378/#review11308
-----------------------------------------------------------


On March 20, 2014, 2:37 p.m., zvision wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3378/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 2:37 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23509
>     https://issues.asterisk.org/jira/browse/ASTERISK-23509
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> SayNumber diaplan application tries to play an invalid/empty sound file (digits/) for numbers divisible by 100 when Polish language is selected.
> First it plays a correct sound (digits/100, for example) and then it tries to play an empty file. The number spelled is correct,
> but Asterisk gives WARNINGs about a missing file.
> 
> The problem is an incorrect check while playing tenths sound - it tries to play a tenths sound when number is 0.
> 
> The patch fixes the problem and clarifies a bit other checks.
> 
> 
> Diffs
> -----
> 
>   http://svn.asterisk.org/svn/asterisk/branches/1.8/main/say.c 410948 
> 
> Diff: https://reviewboard.asterisk.org/r/3378/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zvision
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140320/30343d75/attachment-0001.html>