[asterisk-dev] [Code Review] 3104: PJSIP CLI Part 2

[George Joseph]

> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip_endpoint_identifier_ip.c, line 305
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51197#file51197line305>
> >
> >     Why 14?

That's the adjustment needed to get the output to line up.


> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip_outbound_registration.c, line 1090
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51198#file51198line1090>
> >
> >     I'll stand in for Josh and state that the use of RAII_VAR is gratuitous for s_container since the goal is to actually end up returning it.

The ao2_container_dup can fail later on.


> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip_outbound_registration.c, line 1138
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51198#file51198line1138>
> >
> >     More magic numbers here. What is 53?

It's the fixed width of the registration uri field.


> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip/config_auth.c, line 206
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51192#file51192line206>
> >
> >     No need to use RAII_VAR for s_container.

There's now a failure check and possible early exit later on.


> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip/config_transport.c, line 455
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51193#file51193line455>
> >
> >     No need for RAII_VAR for s_container.

There's now a failure check and possible early exit later on.


> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip/location.c, line 418
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51194#file51194line418>
> >
> >     Another case where s_container doesn't need to use RAII_VAR.

There's now a failure check and possible early exit later on.


> On Jan. 16, 2014, 9:32 a.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip/pjsip_configuration.c, lines 1177-1185
> > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51196#file51196line1177>
> >
> >     Same comments as with previous s_containers.

There's now a failure check and possible early exit later on.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3104/#review10599
-----------------------------------------------------------


On Jan. 6, 2014, 2:49 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3104/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2014, 2:49 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds identify, transport and registration support to the CLI.
> Creates 3 additional callbacks, one for an iterator, one for a comparator and one for a container.  This eliminates the link dependency from higher level modules to lower level ones.
> Eliminates duplicate sorting.
> Cleans up output formatting.
> Pushes cli registration down to the implementing source file.
> Adds several ast_sip_destroy_sorcery functions to complement existing ast_sip_sorcery_initialize functions.  The destroy functions unregister cli commands and cli formatters.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_outbound_registration.c 405000 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 405000 
>   branches/12/res/res_pjsip/pjsip_configuration.c 405000 
>   branches/12/res/res_pjsip/pjsip_cli.c 405000 
>   branches/12/res/res_pjsip/location.c 405000 
>   branches/12/res/res_pjsip/config_transport.c 405000 
>   branches/12/res/res_pjsip/config_auth.c 405000 
>   branches/12/include/asterisk/res_pjsip_cli.h 405000 
>   branches/12/include/asterisk/res_pjsip.h 405000 
> 
> Diff: https://reviewboard.asterisk.org/r/3104/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140116/31ee1219/attachment-0001.html>