[asterisk-dev] [Code Review] 3115: res_pjsip: Fix CLI tab completion issues

opticron reviewboard at asterisk.org
Thu Jan 9 20:21:11 CST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3115/
-----------------------------------------------------------

(Updated Jan. 9, 2014, 8:21 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Kevin's comments.


Bugs: ASTERISK-23081
    https://issues.asterisk.org/jira/browse/ASTERISK-23081


Repository: Asterisk


Description
-------

This fixes several issues with the new res_pjsip CLI tab completion such as output of headers during tab completion and being able to tab-complete more items than the code actually handled (further items would simply be ignored).


Diffs (updated)
-----

  branches/12/res/res_pjsip/pjsip_cli.c 405252 

Diff: https://reviewboard.asterisk.org/r/3115/diff/


Testing
-------

Checked "pjsip show endpoint <endpoint>", "pjsip show endpoints", and "pjsip list endpoints" for proper tab completion behavior.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140110/8013986b/attachment.html>


More information about the asterisk-dev mailing list