[asterisk-dev] [Code Review] 3115: res_pjsip: Fix CLI tab completion issues
Kevin Harwell
reviewboard at asterisk.org
Thu Jan 9 16:55:55 CST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3115/#review10551
-----------------------------------------------------------
branches/12/res/res_pjsip/pjsip_cli.c
<https://reviewboard.asterisk.org/r/3115/#comment20006>
It looks like 'context.output_buffer' needs to be freed for these two paths as well.
- Kevin Harwell
On Jan. 9, 2014, 2:34 p.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3115/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 2:34 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-23081
> https://issues.asterisk.org/jira/browse/ASTERISK-23081
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This fixes several issues with the new res_pjsip CLI tab completion such as output of headers during tab completion and being able to tab-complete more items than the code actually handled (further items would simply be ignored).
>
>
> Diffs
> -----
>
> branches/12/res/res_pjsip/pjsip_cli.c 405252
>
> Diff: https://reviewboard.asterisk.org/r/3115/diff/
>
>
> Testing
> -------
>
> Checked "pjsip show endpoint <endpoint>", "pjsip show endpoints", and "pjsip list endpoints" for proper tab completion behavior.
>
>
> Thanks,
>
> opticron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140109/3afec2d8/attachment.html>
More information about the asterisk-dev
mailing list