[asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3409/#review11759
-----------------------------------------------------------


After talking on Twitter I believe I understand what is going on here.

When you do a "sip reload" any realtime peers in chan_sip are pruned and removed. This is probably causing the device state to change to an incorrect value which app_queue is then using. The change probably works around this by re-checking using any channels that exist.

- Joshua Colp


On April 2, 2014, 12:48 p.m., Shlomi Gutman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3409/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 12:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-16115
>     https://issues.asterisk.org/jira/browse/ASTERISK-16115
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> In some cases when member in talk (IN_USE) and you run "sip reload" or peer has connectivity problems (reachable->unreachable/lagged->reachable) the status of peer is set to NOT_INUSE, while he is still talking.
> The patch adds function that would check if member has any active channel. And would consider him IN_USE if does and if not, would do nothing, as you can't detect what is the state of member if he has no channel.
> 
> Originally patch was used on 1.8.23.0 (can apply it to reviewboard as well) and 11.6-cert1. As well as in my case all peers, queues, memebrs are realtime. But as David Brillert reported in bug, he is not using realtime peers, so it's used for all peers.
> 
> The patch works, the question is if it's the best solution and it would not introduce any regressions.
> 
> 
> Diffs
> -----
> 
>   /branches/11/apps/app_queue.c 411575 
> 
> Diff: https://reviewboard.asterisk.org/r/3409/diff/
> 
> 
> Testing
> -------
> 
> Used in production on 1.8 and 11 and customers having problems approved that problem was resolved.
> 
> 
> Thanks,
> 
> Shlomi Gutman
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140426/b656471d/attachment.html>