[asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

[Shlomi Gutman]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3409/
-----------------------------------------------------------

(Updated April 2, 2014, 12:48 p.m.)


Review request for Asterisk Developers.


Changes
-------

Tried to follow Guidelines and deleted all the extra white spaces.

This patch is important that it double checks the status of member if and it is based on if he has open channel, and if he does he is in call 100%.
Before patch i tried to use the previous functions but it always returned false results.
I'll repeat that in my case i use realtime configuration both for queue members and for peers(sip devices) so it might be related. In my case as well i do run my function only if it's realtime config (call->member->realtime). I deleted it so people with not realtime config can approve if it fixes or not their issues.


Bugs: ASTERISK-16115
    https://issues.asterisk.org/jira/browse/ASTERISK-16115


Repository: Asterisk


Description
-------

In some cases when member in talk (IN_USE) and you run "sip reload" or peer has connectivity problems (reachable->unreachable/lagged->reachable) the status of peer is set to NOT_INUSE, while he is still talking.
The patch adds function that would check if member has any active channel. And would consider him IN_USE if does and if not, would do nothing, as you can't detect what is the state of member if he has no channel.

Originally patch was used on 1.8.23.0 (can apply it to reviewboard as well) and 11.6-cert1. As well as in my case all peers, queues, memebrs are realtime. But as David Brillert reported in bug, he is not using realtime peers, so it's used for all peers.

The patch works, the question is if it's the best solution and it would not introduce any regressions.


Diffs (updated)
-----

  /branches/11/apps/app_queue.c 411575 

Diff: https://reviewboard.asterisk.org/r/3409/diff/


Testing
-------

Used in production on 1.8 and 11 and customers having problems approved that problem was resolved.


Thanks,

Shlomi Gutman

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140402/dc9cc429/attachment.html>