[asterisk-dev] [Code Review] 2873: Stasis performance improvements

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2873/
-----------------------------------------------------------

(Updated Sept. 27, 2013, 12:59 p.m.)


Review request for Asterisk Developers.


Changes
-------

Review feedback.
* Removed min size from ao2_alloc()
* Removed table_has_route(); replace with table_find_route()
* Added assertion to find_route()


Repository: Asterisk


Description
-------

This patch addresses several performance problems that were found in
the initial performance testing of Asterisk 12.

The Stasis dispatch object was allocated as an AO2 object, even though
it has a very confined lifecycle. This was replaced with a straight
ast_malloc().

The Stasis message router was spending an inordinate amount of time
searching hash tables. In this case, most of our routers had 6 or
fewer routes in them to begin with. This was replaced with an array
that's searched linearly for the route.

We more heavily rely on AO2 objects in Asterisk 12, and the memset()
in ao2_ref() actually became noticeable on the profile. This was
#ifdef'ed to only run when AO2_DEBUG was enabled.

After being misled by an erroneous comment in taskprocessor.c during
profiling, the wrong comment was removed.


Diffs (updated)
-----

  /branches/12/include/asterisk/stasis_message_router.h 399650 
  /branches/12/main/astobj2.c 399650 
  /branches/12/main/stasis.c 399650 
  /branches/12/main/stasis_message_router.c 399650 
  /branches/12/main/taskprocessor.c 399650 
  /branches/12/res/res_pjsip/include/res_pjsip_private.h 399650 
  /branches/12/tests/test_stasis.c 399650 

Diff: https://reviewboard.asterisk.org/r/2873/diff/


Testing
-------

Unit tests pass.

Using the setup below, sipp was run against the 12 branch both with
and without my changes.

==
[test-server]$ cat extensions.conf 

[performance]
exten => service,1,Answer
exten => service,n,Wait(1)
exten => service,n,Hangup

[test-server]$ cat sip.conf 

[perf](!)
type=peer
qualify=no
disallow=all
allow=g722
allow=ulaw
insecure=invite,port
context=performance

[test-client](perf)
host=test-client

Simple sipp scenario:
[test-client]$ sipp -sn uac -l 100 -r 50 tests-server


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130927/877501de/attachment-0002.html>