[asterisk-dev] [Code Review] 2874: Allow Asterisk to retry after 403 on register
Matt Jordan
reviewboard at asterisk.org
Fri Sep 27 07:53:34 CDT 2013
> On Sept. 26, 2013, 9:54 p.m., Paul Belanger wrote:
> > /trunk/configs/sip.conf.sample, line 790
> > <https://reviewboard.asterisk.org/r/2874/diff/1/?file=46103#file46103line790>
> >
> > why do we need a new configuration option? Can we not use registertimeout?
>
> Matt Jordan wrote:
> Having this always enabled feels like a huge change in behavior midstream. This needs to be:
> * Disabled be default
> * An option to enable this behavior if someone needs it
>
> That keeps this from becoming a breaking change in the middle of Asterisk 1.8/11.
>
> opticron wrote:
> Matt: It is not enabled by default. I'll fix the config addition.
>
> Paul: I'm not sure I understand your question. This is a new behavior that allows Asterisk to work around an RFC-suggested behavior (SHOULD NOT continue retrying on 403). I'd prefer not to co-opt an existing config option to enable this work around.
Heh, I wasn't implying that it was enabled by default. I should have probably been a bit clearer - repurposing the registertimeout parameter as a means to control this behavior would have enabled it in situations where it wasn't previously.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2874/#review9812
-----------------------------------------------------------
On Sept. 23, 2013, 7:48 p.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2874/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2013, 7:48 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-17138
> https://issues.asterisk.org/jira/browse/ASTERISK-17138
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This adds an option in chan_sip and chan_pjsip to allow them to continue attempting registration if a 403 is received. Normally, this would cause registration attempts to that endpoint to stop.
>
> In the case of chan_sip, this global option simply allows registration to continue past a 403 as if it was a non-fatal reply to retry later.
>
> For chan_pjsip, this is a per outbound registration option that takes an interval in seconds to wait after a 403 to try again.
>
>
> Diffs
> -----
>
> /trunk/channels/chan_sip.c 399644
> /trunk/configs/pjsip.conf.sample 399644
> /trunk/configs/sip.conf.sample 399644
> /trunk/res/res_pjsip_outbound_registration.c 399644
>
> Diff: https://reviewboard.asterisk.org/r/2874/diff/
>
>
> Testing
> -------
>
> Tests are available in the following review:
> https://reviewboard.asterisk.org/r/2875/
>
>
> Thanks,
>
> opticron
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130927/eb99ce6c/attachment-0002.html>
More information about the asterisk-dev
mailing list