[asterisk-dev] [Code Review] 2846: Finish conversion script from sip.conf to pjsip.conf

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2846/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 9 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address Kinsey's review feedback.


Bugs: ASTERISK-22374
    https://issues.asterisk.org/jira/browse/ASTERISK-22374


Repository: Asterisk


Description
-------

This finishes off the initial work on the conversion script from sip.conf to pjsip.conf. This addresses missing endpoint options, registration options, auth options, and transport options.

I ran the flake8 checker on the files, but I only corrected its complaints in the new sections I added in order to keep the diff reduced to the relevant changes. Unfortunately, this ended up being moot since I renamed the files and the directory that they are in.


Diffs (updated)
-----

  /trunk/contrib/scripts/sip_to_pjsip/astdicts.py PRE-CREATION 
  /trunk/contrib/scripts/sip_to_pjsip/astconfigparser.py PRE-CREATION 
  /trunk/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py PRE-CREATION 
  /trunk/contrib/scripts/sip_to_res_sip/astconfigparser.py 399909 
  /trunk/contrib/scripts/sip_to_res_sip/astdicts.py 399909 
  /trunk/contrib/scripts/sip_to_res_sip/sip_to_res_sip.py 399909 

Diff: https://reviewboard.asterisk.org/r/2846/diff/


Testing
-------

Tested against various sip.conf files to ensure that generated sections had the expected data in them.


Thanks,

Mark Michelson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130926/9f810523/attachment-0002.html>