[asterisk-dev] [Code Review] 2887: astobj2: Remove OBJ_CONTINUE support.

rmudgett reviewboard at asterisk.org
Thu Sep 26 13:04:12 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2887/
-----------------------------------------------------------

Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

OBJ_CONTINUE was a strange feature that came into the world under suspicious circumstances to support an abuse of the ao2_container by chan_iax2.  Since chan_iax2 no longer uses OBJ_CONTINUE, it is safe to remove it.

The simplified code should help performance slightly and make understanding the code easier.


Diffs
-----

  /branches/12/tests/test_astobj2.c 399893 
  /branches/12/main/astobj2.c 399893 
  /branches/12/include/asterisk/astobj2.h 399893 

Diff: https://reviewboard.asterisk.org/r/2887/diff/


Testing
-------

ao2 containers still pass the unit tests after the OBJ_CONTINUE unit test was removed.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130926/7adcd480/attachment-0001.html>


More information about the asterisk-dev mailing list