[asterisk-dev] [Code Review] 2855: Test Suite: New parameters for PluggableModules.Originator to control originations triggered by scenario_start

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2855/#review9772
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/PluggableModules.py
<https://reviewboard.asterisk.org/r/2855/#comment18973>

    It appears self.scenario_name is otherwise unused



/asterisk/trunk/sample-yaml/originator-config.yaml.sample
<https://reviewboard.asterisk.org/r/2855/#comment18975>

    The config name 'scenario-count' doesn't make sense to me for what this does.  'scenario-index' or something like that seems more appropriate.  On first glance I expected scenario-count would specify how many scenario's should trigger the originate (like a limit).


- Corey Farrell


On Sept. 13, 2013, 6:02 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2855/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 6:02 p.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> PluggableModules.Originator works fine when a single SIPp scenario and single Originator pluggable module is used for a test. However when more than one of each is used for a test, failures are likely to occur. This is because for each SIPp scenario that starts an origination will occur for every Originator module loaded that is using the scenario_start trigger.
> 
> This adds two new optional parameters that may be used in conjunction with a trigger of 'scenario_start'. These help control when an origination occurs, prevent multiple originations from occurring, and correspond a scenario start to a specific scenario. Only one of the parameters may be specified per originator config section.
> 
> New parameters:
> * scenario-count - Originate only when the specified number of scenario start triggers occur.
> * scenario-name - Originate only when the specified scenario is started.
> 
> I have updated two tests to use the scenario_start trigger with these new parameters that are included on this review:
> * bob_incompatible_codecs - this is updated to use the 'scenario-count' parameter. One SIPp scenario file is used for all the SIPp instances. No origination will occur until all SIPp scenarios have started and each Originator will only originate a single call.
> * bob_is_busy - this is updated to use the 'scenario-name' parameter. Multiple copies of the SIPp scenario file were made with each having a unique name to allow the use of this new parameter. For each SIPp scenario that is started only a single origination will occur matching by the scenario file name.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/PluggableModules.py 4188 
>   /asterisk/trunk/sample-yaml/originator-config.yaml.sample 4188 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_incompatible_codecs/test-config.yaml 4188 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv4-tcp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv4-udp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv6-tcp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive-ipv6-udp.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/sipp/receive.xml 4188 
>   /asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy/test-config.yaml 4188 
> 
> Diff: https://reviewboard.asterisk.org/r/2855/diff/
> 
> 
> Testing
> -------
> 
> * Executed the modified tests which all pass.
> * For each of the modified tests the logs show that only a single call is originated.
> * A call is originated only when the scenario-name matches the SIPp scenario that started for the test using the 'scenario-name' parameter.
> * Ensured that without specifying either of the new parameters, the originate works as it did before.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130924/bb8b6b8c/attachment-0001.html>