[asterisk-dev] [Code Review] 2853: chan_sip: Make T.38 reinvites put Asterisk in the media path for the image

[svnbot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2853/
-----------------------------------------------------------

(Updated Sept. 19, 2013, 11:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, Joshua Colp and Mark Michelson.


Changes
-------

Committed in revision 399456


Bugs: ASTERISK-17273
    https://issues.asterisk.org/jira/browse/ASTERISK-17273


Repository: Asterisk


Description
-------

Currently, if a direct media call is already set up when a reinvite is issued to include an image stream, the SDP still includes the opposed peer both in the reinvite that we send to the phone that didn't initiate the T.38 reinvite and in the 200 OK sent back to the phone that did. This will mean that Asterisk won't be in the media path. This is also a problem because the port used for the udptl in the m=image section is the port that Asterisk will use for the T.38 session instead of the port the opposite device sent to use.

This patch fixes it so that, at least for the image portion of the SDP, a C field will be put in the image section that uses Asterisk's IP and socket address.


Diffs
-----

  /branches/1.8/channels/chan_sip.c 399015 

Diff: https://reviewboard.asterisk.org/r/2853/diff/


Testing
-------

I'm currently finishing up a test that confirms the presence of the c= fields that we would expect in the SDP which will be posted shortly.  It passes with the patch and fails without the patch.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130919/b8019671/attachment.htm>