[asterisk-dev] [Code Review] 2833: res_pjsip_messaging: Register message technology as pjsip

[Kevin Harwell]

> On Sept. 17, 2013, 7:47 p.m., Mark Michelson wrote:
> > branches/12/res/res_pjsip_messaging.c, line 233
> > <https://reviewboard.asterisk.org/r/2833/diff/3/?file=45896#file45896line233>
> >
> >     Any particular reason you're using pj_memcpy() instead of a normal memcpy()?
> >     
> >     (Same question applies to other uses in this function)

No good reason really.  Initially, I thought they accepted a pj_str_t, but they don't so can just use memcpy.  I will change it before committing. 


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2833/#review9722
-----------------------------------------------------------


On Sept. 13, 2013, 2:43 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2833/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 2:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22445
>     https://issues.asterisk.org/jira/browse/ASTERISK-22445
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> pjsip's message technology was being registered as 'sip', which was causing it to not load due it conflicting with chan_sip's registered 'sip' technology for messaging.  It now registers as 'pjsip'.  However, due to this change the "to" field for outgoing pjsip messages need to be prefixed with 'pjsip:' instead of 'sip:'.  Incoming messages to res_pjsip_messaging will automatically have their "to" fields altered in order to accommodate the change.  Outgoing messages also handle changing it back to 'sip' before being sent so the pjsip library will properly handle it.
> 
> 
> Diffs
> -----
> 
>   branches/12/res/res_pjsip_messaging.c 399006 
> 
> Diff: https://reviewboard.asterisk.org/r/2833/diff/
> 
> 
> Testing
> -------
> 
> Updated the pjsip messaging testsuite tests and made sure passed.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130917/86fd81f2/attachment.htm>