[asterisk-dev] [Code Review] 2865: Testsuite: Add SIP un-register Tests
Mark Michelson
reviewboard at asterisk.org
Tue Sep 17 15:06:43 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2865/#review9726
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Michelson
On Sept. 17, 2013, 7:09 p.m., Michael Young wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2865/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2013, 7:09 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-22548
> https://issues.asterisk.org/jira/browse/ASTERISK-22548
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> While working on ASTERISK-22428, a regression was discovered. The 200 ok sent by Asterisk after a peer un-registers contains a "Contact" header with ";expires" and "Expires:" header not being 0, as was requested by the peer.
>
> These tests have peers register to Asterisk over IPv4 / IPv6 and then un-register themselves. The tests also take in to consideration authenticated registrations and non-authenticated registrations.
>
> The tests are looking for a successful registration and after sending an un-register requests, examines the 200 ok. The tests expect the 200 ok not to contain a "Contact" header and it expects the "Expires" header to be set to 0.
>
>
> Diffs
> -----
>
> /asterisk/trunk/tests/channels/SIP/sip_unregister/configs/ast1/sip.conf PRE-CREATION
> /asterisk/trunk/tests/channels/SIP/sip_unregister/sipp/registerv4-auth.xml PRE-CREATION
> /asterisk/trunk/tests/channels/SIP/sip_unregister/sipp/registerv4.xml PRE-CREATION
> /asterisk/trunk/tests/channels/SIP/sip_unregister/sipp/registerv6-auth.xml PRE-CREATION
> /asterisk/trunk/tests/channels/SIP/sip_unregister/sipp/registerv6.xml PRE-CREATION
> /asterisk/trunk/tests/channels/SIP/sip_unregister/test-config.yaml PRE-CREATION
> /asterisk/trunk/tests/channels/SIP/tests.yaml 4200
>
> Diff: https://reviewboard.asterisk.org/r/2865/diff/
>
>
> Testing
> -------
>
> Tests were run on dev box using Asterisk Trunk. The tests fail without the patch that is currently up on ASTERISK-22428. With the patch, the tests pass.
>
>
> Thanks,
>
> Michael Young
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130917/c4cfaa79/attachment.htm>
More information about the asterisk-dev
mailing list