[asterisk-dev] [Code Review] 2857: bridge_softmix: Add a warning when no timing source is available

[Olle E Johansson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2857/#review9708
-----------------------------------------------------------


Without understanding the source code, I just have to say that I really support adding warnings like this, that make it easier to manager and understand Asterisk.

- Olle E Johansson


On Sept. 15, 2013, 3:22 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2857/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 3:22 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While tinkering with ConfBridge on an Asterisk setup with a limited set of modules installed, I ran into an error reported from ConfBridge that it couldn't create a bridge due to a failure to create a softmix bridge. Unfortunately, bridge_softmix itself didn't relay why it wasn't created.
> 
> Inspecting the code revealed there are three ways creation of a softmix bridge can fail:
>  1. Memory allocation failure
>  2. NULL returned from ast_timer_open
>  3. Thread creation failure
> 
> 1 and 3 are both unlikely and likely to output an error from their respective routines. Number 2, however, is silent if no timing module is loaded.
> 
> This patch adds a warning on that off nominal path.
> 
> A lot of folks run Asterisk without a timing source (for whatever reason), which means - since softmix bridges will be used a lot more and in more places in 12 than in the past - a WARNING here is pretty useful.
> 
> 
> Diffs
> -----
> 
>   /branches/11/bridges/bridge_softmix.c 398805 
> 
> Diff: https://reviewboard.asterisk.org/r/2857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130915/1b368db8/attachment-0001.htm>