[asterisk-dev] [Code Review] 2851: chan_sip: Remove requirement for resolving host when outbound proxy in use

[Joshua Colp]

> On Sept. 13, 2013, 2:32 p.m., Olle E Johansson wrote:
> > I hope to be able to test this in combination with my DNS SRV work, which also removes DNSmgr from the equation.
> > 
> > We need to test both with a record-routing ob proxy and one that doesn't so we make sure we follow the route and NOT send the second transaction in a dialog to the ob proxy by default. There used to be a "force" parameter to force that behaviour if needed.
> > 
> > /O

The changes here haven't impacted the actual outbound proxy code, I've left that alone. Based on my comparison and reading I don't *think* that should have been impacted between 1.4 and 1.8, but who knows. If that does end up being the case then instead of overloading these issues and this review we can create a master outbound proxy issue and report/coordinate/work from there.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2851/#review9702
-----------------------------------------------------------


On Sept. 13, 2013, 1:53 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2851/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2013, 1:53 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21231 and ASTERISK-21694
>     https://issues.asterisk.org/jira/browse/ASTERISK-21231
>     https://issues.asterisk.org/jira/browse/ASTERISK-21694
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> During the development of 1.8 chan_sip was moved to using dnsmgr for host resolution. These changes introduced a regression where all hosts were looked up in DNS, including when an outbound proxy is in use. This is incorrect. The attached change removes this requirement.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 398742 
> 
> Diff: https://reviewboard.asterisk.org/r/2851/diff/
> 
> 
> Testing
> -------
> 
> Configured an outbound proxy at global and peer level, confirmed that no resolution occurs for the host and also that traffic goes to where it should. Removed outbound proxy and confirmed things returned to normal.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130913/1f030292/attachment-0001.htm>