[asterisk-dev] [Code Review] 2836: Testsuite: pjsip messaging tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2836/#review9697
-----------------------------------------------------------



./tests/channels/pjsip/message/message_basic/test-config.yaml
<https://reviewboard.asterisk.org/r/2836/#comment18860>

    This description is misleading. It sounds like there is one party that sends a MESSAGE to Asterisk, and then Asterisk echoes the MESSAGE back to the party that sent it.
    
    Other tests have similar language in them, so I won't bother putting similar comments on them.


- Mark Michelson


On Sept. 9, 2013, 2:58 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2836/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 2:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Testsuite tests for pjsip messaging.  Some have been ported from the old sip messaging tests (chan_sip) and have been updated to work with the new sip channel driver.  Tests include messages with custom headers, messages from various identifiers, in dialog messaging, and messages via ami.
> 
> 
> Diffs
> -----
> 
>   ./tests/channels/pjsip/message/message_basic/configs/ast1/extensions.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_basic/configs/ast1/pjsip.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_basic/sipp/message.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_basic/sipp/message_recv.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_basic/test-config.yaml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_cust_hdr/configs/ast1/extensions.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_cust_hdr/configs/ast1/pjsip.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_cust_hdr/sipp/message.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_cust_hdr/sipp/message_recv.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_cust_hdr/test-config.yaml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_from/configs/ast1/extensions.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_from/configs/ast1/pjsip.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_from/sipp/message.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_from/sipp/message_recv.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_from/test-config.yaml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/configs/ast1/extensions.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/configs/ast1/pjsip.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/sipp/message.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/sipp/message.xml.old PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/sipp/message_recv.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/sipp/message_recv.xml.old PRE-CREATION 
>   ./tests/channels/pjsip/message/message_in_dialog/test-config.yaml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_send_ami/configs/ast1/extensions.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_send_ami/configs/ast1/manager.users.conf.inc PRE-CREATION 
>   ./tests/channels/pjsip/message/message_send_ami/configs/ast1/pjsip.conf PRE-CREATION 
>   ./tests/channels/pjsip/message/message_send_ami/run-test PRE-CREATION 
>   ./tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml PRE-CREATION 
>   ./tests/channels/pjsip/message/message_send_ami/test-config.yaml PRE-CREATION 
>   ./tests/channels/pjsip/message/tests.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2836/diff/
> 
> 
> Testing
> -------
> 
> Ran test against 12 to make sure they completed successfully.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/08d2521d/attachment-0001.htm>