[asterisk-dev] [Code Review] 2833: res_pjsip_messaging: Register message technology as pjsip

Kevin Harwell reviewboard at asterisk.org
Thu Sep 12 15:34:06 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2833/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 8:34 p.m.)


Review request for Asterisk Developers.


Changes
-------

Check the size of the given buffer in 'scheme_sip_to_pjsip' to make sure it can hold the formed uri.


Bugs: ASTERISK-22445
    https://issues.asterisk.org/jira/browse/ASTERISK-22445


Repository: Asterisk


Description
-------

pjsip's message technology was being registered as 'sip', which was causing it to not load due it conflicting with chan_sip's registered 'sip' technology for messaging.  It now registers as 'pjsip'.  However, due to this change the "to" field for outgoing pjsip messages need to be prefixed with 'pjsip:' instead of 'sip:'.  Incoming messages to res_pjsip_messaging will automatically have their "to" fields altered in order to accommodate the change.  Outgoing messages also handle changing it back to 'sip' before being sent so the pjsip library will properly handle it.


Diffs (updated)
-----

  branches/12/res/res_pjsip_messaging.c 398225 

Diff: https://reviewboard.asterisk.org/r/2833/diff/


Testing
-------

Updated the pjsip messaging testsuite tests and made sure passed.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/a8d7cdaf/attachment.htm>


More information about the asterisk-dev mailing list