[asterisk-dev] [Code Review] 2825: Remote console: more output discrepancies

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2825/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 7:37 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed finding: The verbose prefix information is now added to each new line *after* applying the "ap" argument.

The odd things was is that I did not see this occur on my machine despite the bug being there.  I would have expected it to show itself with every run.  Because of that I suspected another bug on the output side.  Sure enough if the string data being sent to the remote console segmented itself between a magic value and the prefix it would cause the output to show incorrectly.  So if you ran it 'n' times it might look fine, but on 'n+1' it could segment in the wrong place and mess things up.

Hopefully the new patch sufficiently fixes both of these issues and output will remain consistent among the consoles.


Bugs: ASTERISK-22450
    https://issues.asterisk.org/jira/browse/ASTERISK-22450


Repository: Asterisk


Description
-------

This is a follow up to https://reviewboard.asterisk.org/r/2798/

The remote console continued to have issues with its output.  In this case CLI command output would either not show up (if verbose level = 0) or would contain verbose prefixes (if verbose level > 0) once log messages were sent to the remote console.  The fix now distinguishes between verbose log messages and cli command output sent to a remote console.


Diffs (updated)
-----

  branches/11/main/asterisk.c 398807 
  branches/11/main/logger.c 398807 

Diff: https://reviewboard.asterisk.org/r/2825/diff/


Testing
-------

Duplicated issues.  Then ran scenarios again and observed that the issues were no longer occurring.  Also tried several other combinations of log levels and cli commands between consoles (local/remote).


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/ac366fdd/attachment.htm>