[asterisk-dev] [Code Review] 2843: res_pjsip: crash when using localnet and external_signaling_address options

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2843/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 4:29 p.m.)


Review request for Asterisk Developers.


Changes
-------

Addressed findings.


Bugs: ASTERISK-22394
    https://issues.asterisk.org/jira/browse/ASTERISK-22394


Repository: Asterisk


Description
-------

There was a collision of mod_data use on the transaction between using a nat hook and an session response callback.  During state change it was assumed what was in the mod_data was nothing or the response callback.  However, it was possible for it to also contain a nat hook thus resulting in a bad cast and a crash.

Added the ability to store multiple data elements in mod_data via a hash table.  In this instance, mod_data now stores a hash table of the two values that can be retrieved using an associated string key.


Diffs (updated)
-----

  branches/12/include/asterisk/res_pjsip.h 398800 
  branches/12/res/res_pjsip.c 398800 
  branches/12/res/res_pjsip.exports.in 398800 
  branches/12/res/res_pjsip_session.c 398800 

Diff: https://reviewboard.asterisk.org/r/2843/diff/


Testing
-------

Configured pjsip and made several calls to make sure the crash no longer occurred and everything still worked as expected with and without using the localnet and external_signaling_address_option(s).


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130912/5a809bb4/attachment.htm>