[asterisk-dev] [Code Review] 2814: testsuite: bridge/parkcall test update for res_parking module and related changes.

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2814/#review9659
-----------------------------------------------------------

Ship it!


+1 for PEP8. Just a couple of minor nits.


/asterisk/trunk/tests/bridge/parkcall/Executioner.py
<https://reviewboard.asterisk.org/r/2814/#comment18810>

    The field names in this message are wrong for Asterisk 12+.



/asterisk/trunk/tests/bridge/parkcall_bridgefeatures/Executioner.py
<https://reviewboard.asterisk.org/r/2814/#comment18811>

    The field names in this message are wrong for Asterisk 12+.


- David Lee


On Sept. 4, 2013, 8:32 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2814/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 8:32 a.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22328
>     https://issues.asterisk.org/jira/browse/ASTERISK-22328
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> CDR logging and some test events have been changed in Asterisk12 since res_parking went in and this has caused some tests to no longer be compatible. This update changes event expectations to be compatible with 12 and also changes expectations for CDRs to address the fact that a separate CDR log is created for which ever device ends up being parked from the initial one to one call CDR log.
> 
> Further, the BRIDGE_FEATURES variant of the test phases have been split off into their own test since the BRIDGE_FEATURES variable only works properly in 12.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/tests.yaml 4081 
>   /asterisk/trunk/tests/bridge/parkcall_bridgefeatures/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_bridgefeatures/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall_bridgefeatures/Executioner.py PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall/test-config.yaml 4081 
>   /asterisk/trunk/tests/bridge/parkcall/configs/ast1/extensions.conf 4081 
>   /asterisk/trunk/tests/bridge/parkcall/Executioner.py 4081 
> 
> Diff: https://reviewboard.asterisk.org/r/2814/diff/
> 
> 
> Testing
> -------
> 
> Ran tests against 11 and 12 to make sure they each pass.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130911/4a68e970/attachment-0001.htm>