[asterisk-dev] [Code Review] 2831: pjsip: reinvite for connected line updates occurs when it should not

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2831/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 9:38 p.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Updated per review finding.


Bugs: AST-1212
    https://issues.asterisk.org/jira/browse/AST-1212


Repository: Asterisk


Description
-------

Connected line updates are now only sent out if an actual update needs to occur.  This happens under the following conditions:

1. The endpoint we are sending to is trusted.
2. Either a P-Asserted-Identity or Remote Party-ID header needs to be added/sent.
3. The connected id's number and name are valid.

Also added an SDP when an update is sent out.


Diffs (updated)
-----

  branches/12/channels/chan_pjsip.c 398520 
  branches/12/res/res_pjsip_caller_id.c 398520 

Diff: https://reviewboard.asterisk.org/r/2831/diff/


Testing
-------

Saw this issue occur while running a messaging testsuite test causing it to fail.  Ran the test again after the fix was put in and it no longer happens.


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130909/1c9c0216/attachment.htm>