[asterisk-dev] [Code Review] 2825: Remote console: more output discrepancies

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2825/
-----------------------------------------------------------

(Updated Sept. 9, 2013, 9:17 p.m.)


Review request for Asterisk Developers.


Changes
-------

Based on some feedback removed the "magic" cli value.  Instead, for each verbose logging statement make sure that all newlines in a given log statement contain the appropriate prefix and magic values.


Bugs: ASTERISK-22450
    https://issues.asterisk.org/jira/browse/ASTERISK-22450


Repository: Asterisk


Description
-------

This is a follow up to https://reviewboard.asterisk.org/r/2798/

The remote console continued to have issues with its output.  In this case CLI command output would either not show up (if verbose level = 0) or would contain verbose prefixes (if verbose level > 0) once log messages were sent to the remote console.  The fix now distinguishes between verbose log messages and cli command output sent to a remote console.


Diffs (updated)
-----

  branches/11/main/asterisk.c 398227 
  branches/11/main/logger.c 398227 

Diff: https://reviewboard.asterisk.org/r/2825/diff/


Testing
-------

Duplicated issues.  Then ran scenarios again and observed that the issues were no longer occurring.  Also tried several other combinations of log levels and cli commands between consoles (local/remote).


Thanks,

Kevin Harwell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130909/313f93b1/attachment-0001.htm>