[asterisk-dev] [Code Review] 2825: Remote console: more output discrepancies

[Tilghman Lesher]

> On Sept. 5, 2013, 5:08 a.m., Tilghman Lesher wrote:
> > It's not clear why adding a magic value for cli output is the answer here.
> 
> Kevin Harwell wrote:
>     There must be a way to tell if incoming text on a remote console are log messages vs. cli output. 
>     
>     Say for instance the log level was 3 on the remote console and a few lines of log messages had been sent to it.  At this point the last known log level was 3.  Now a cli output message is sent to the remote console and since it has no "magic" the last known log level was assumed and it would print the cli output using the verbose level 3 prefix.
>     
>     By adding a "magic" value to the cli output going to a remote console it can now tell the difference between incoming log messages and cli output and print them appropriately.
> 
> Tilghman Lesher wrote:
>     A magic value is only supposed to be good until a newline.  Once you hit the newline, you reset back to cli output unless you see another magic value directly after the newline character.
> 
> Kevin Harwell wrote:
>     There are some scenarios where that would fail, thus the discrepancies.  For instance, if someone did the following:
>     
>     ast_verb(3, "hello\nworld\n");
>     
>     That would only output the level 3 prefix for the "hello" and then no prefix for "world".  Another example would be if there is no newline:
>     
>     ast_verb(3, "hello world");
>     
>     If cli output is received the first line would be on the same line as the log message.  If another verbose log message, say at level 2, was issued it would also show up appended to the level 3 message.

If either of those cases existed in the code, they should definitely be fixed.  It's kind of hard to argue, "Well, if there are bugs in the code, then things don't work correctly, so we should code around it, instead of fixing those bugs."  Think about it.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2825/#review9594
-----------------------------------------------------------


On Sept. 6, 2013, 4:14 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2825/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 4:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22450
>     https://issues.asterisk.org/jira/browse/ASTERISK-22450
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This is a follow up to https://reviewboard.asterisk.org/r/2798/
> 
> The remote console continued to have issues with its output.  In this case CLI command output would either not show up (if verbose level = 0) or would contain verbose prefixes (if verbose level > 0) once log messages were sent to the remote console.  The fix now distinguishes between verbose log messages and cli command output sent to a remote console.
> 
> 
> Diffs
> -----
> 
>   branches/11/include/asterisk/cli.h 398227 
>   branches/11/main/asterisk.c 398227 
>   branches/11/main/cli.c 398227 
>   branches/11/main/logger.c 398227 
> 
> Diff: https://reviewboard.asterisk.org/r/2825/diff/
> 
> 
> Testing
> -------
> 
> Duplicated issues.  Then ran scenarios again and observed that the issues were no longer occurring.  Also tried several other combinations of log levels and cli commands between consoles (local/remote).
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130906/ef6ecd96/attachment.htm>