[asterisk-dev] [Code Review] 2821: testsuite: Update tests/bridge/automon and tests/bridge/automixmon to accomodate Asterisk 12 CEL changes

[jrose]

> On Sept. 5, 2013, 7:02 p.m., Mark Michelson wrote:
> > With this and the other CEL-related tests I'm putting "Ship it!s" on, I'd recommend getting a second opinion from Matt or Kinsey since they are likely more familiar with the CEL workings in Asterisk and the testsuite. That being said, Ship it!

I have to wait for r2799's library changes to go in before I commit these anyway :P


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2821/#review9605
-----------------------------------------------------------


On Sept. 3, 2013, 10:51 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2821/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 10:51 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-22325
>     https://issues.asterisk.org/jira/browse/ASTERISK-22325
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Uses python library changes from https://reviewboard.asterisk.org/r/2799/ to add AMI functionality for IDs/before and after ID event matching
> 
> The reasons for this change are basically the same as with disconnect and the added test module for each test is very similar.
> In addition, the method of applying the features with the BRIDGE_FEATURES channel variable was split into a separate test for each test to be able to run the base tests against Asterisk 11. As a side benefit, there are four faster, smaller tests which test less now instead of two somewhat larger tests.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/automixmon/configs/ast1/extensions.conf 4102 
>   /asterisk/trunk/tests/bridge/automixmon/test-config.yaml 4102 
>   /asterisk/trunk/tests/bridge/automon/configs/ast1/extensions.conf 4102 
>   /asterisk/trunk/tests/bridge/automixmon_bridgefeatures/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/automixmon_bridgefeatures/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/tests.yaml 4102 
>   /asterisk/trunk/tests/bridge/automon_bridgefeatures/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/automon_bridgefeatures/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/automon/test-config.yaml 4102 
> 
> Diff: https://reviewboard.asterisk.org/r/2821/diff/
> 
> 
> Testing
> -------
> 
> Ran each test against 11 and 12 (the BRIDGE_FEATURES variants to make sure they would be skipped against 11). Ran the tests against 12 numerous times to make sure they wouldn't fail under any of the potential orderings of CEL logs that I have encountered so far.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130905/f366f446/attachment.htm>